Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: npm WARN deprecated isarray@2.0.1: Just use Array.isArray directly #77

Closed
swyxio opened this issue Oct 8, 2017 · 1 comment

Comments

@swyxio
Copy link
Contributor

swyxio commented Oct 8, 2017

when i npm install this repo i get this warning npm WARN deprecated isarray@2.0.1: Just use Array.isArray directly . im not sure how to track down this dependency since its not a direct dependency of this repo - any ideas on how I can get it out?

@bvaughn
Copy link
Contributor

bvaughn commented Oct 8, 2017

Sure! Yarn has a command why for just this reason:

$ yarn why isarray
Using globally installed version of Yarn
yarn why v1.0.0
[1/4] 🤔  Why do we have the module "isarray"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
info Has been hoisted to "isarray"
info Reasons this module exists
   - "eslint#doctrine" depends on it
   - "eslint#concat-stream#readable-stream" depends on it
   - "gatsby#yurnalist#markdown-toc#object.pick#isobject" depends on it
info Disk size without dependencies: "32kB"
info Disk size with unique dependencies: "32kB"
info Disk size with transitive dependencies: "32kB"
info Number of shared dependencies: 0
✨  Done in 0.86s.

I don't think we need an open issue for this since it's just a local, dev-warning and it won't harm anything unless we choose to upgrade our yarn.lock file in the future. But I'd be happy to accept a PR if you're able to chase down the fix upstream. 😄

You could try running yarn upgrade-interactive to see if it resolves the issue. After doing so though I'd be sure everything builds correctly from scratch:

rm -rf node_modules
rm -rf .cache
yarn install # Fresh install
yarn build # Make sure Gatsby can create a production build
cd public # Production build goes here
serve # Make sure production build works at localhost:5000
yarn dev # Make Gatsby's dev mode works at localhost:8000

@bvaughn bvaughn closed this as completed Oct 8, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* Add initial translation for HOCs

* Add some more translated paragraphs

* Finish translation

* Remove top comment

* Fix small typo

* Fix fowardRef to forwardRef

* Fix accentuation typo

Co-Authored-By: victorfsf <victorfsf.dev@gmail.com>

* Fix wrong heading

* Apply suggestions from code review

Co-Authored-By: victorfsf <victorfsf.dev@gmail.com>

* Apply more suggestions from code review

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants