Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions page and nav version #6814

Merged
merged 6 commits into from Apr 30, 2024
Merged

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Apr 29, 2024

Preview

Overview

For React 19, we need to remove all of the removed APIs from the docs. This poses a problem for users on older versions, who still need access to docs for removed APIs before they've upgraded to 19.

In this PR, I add a versions page that:

  • Lists the pinned links to old docs versions
  • Explains that we maintain old docs per major version
  • Lists the changelog and relevant blog posts and talks per major release
  • Shows the initial commit and open source release talk from 2013
  • Adds redirects

Screenshot

Screenshot 2024-04-29 at 6 35 45 PM

Initial Commit

This is fun

Screenshot 2024-04-29 at 6 35 52 PM

Testing

Tested on light mode and dark mode, on desktop and mobile.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 10:39pm

Copy link

github-actions bot commented Apr 29, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 80.31 KB (🟡 +105 B) 184.39 KB
/500 80.3 KB (🟡 +105 B) 184.39 KB
/[[...markdownPath]] 82.12 KB (🟡 +107 B) 186.21 KB
/errors 80.51 KB (🟡 +105 B) 184.6 KB
/errors/[errorCode] 80.49 KB (🟡 +105 B) 184.58 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Collaborator

@noahlemen noahlemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! should the "previous versions" links be in a bulleted list, for consistent formatting with the rest of the page?

src/content/versions.md Outdated Show resolved Hide resolved
@rickhanlonii
Copy link
Member Author

Talked with the team, I think we will want to keep the "current" version at react.dev as 18 + canary for now, so I'll add a "Future Versions" section to the page with a link to a React 19 branch.

Then for #6811 we'll land it on the 19 branch and i'll manually keep changes in sync between the two until 19 stable is out.

src/content/versions.md Outdated Show resolved Hide resolved
@rickhanlonii rickhanlonii merged commit 3981ffe into reactjs:main Apr 30, 2024
5 checks passed
@rickhanlonii rickhanlonii deleted the rh/versions branch April 30, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants