Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert "Canary" callouts to "React 19 beta" #6811

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Apr 28, 2024

Overview

Update: The base branch is v19 since these are React 19 specific

Note: this is included in one PR to minimize the number of conflicts with the translation repos.

Now that the React 19 beta is out, the callouts on the page can be converted to specify "React 19 beta" for the features that are in React 19. I also switched the React Server Components callouts to it's own callout type, since the important notice there is not the specific release but the environment they run in.

Included in this PR:

  • Adds the <NextMajor> and <RSC> callout components, similar to the ` callout.
  • Adds the <NextMajorBadge> and <RSCBadge> components, similar to <CanaryBadge>
  • Switches the sidebar metadata from just canary with an enum canary | major
  • Adds React 19 badges to sidebar items
  • Updates text for callouts

Note on the text: the text says "available in React 19 beta and the React canary channel". This is so users who are using the canary with these features today will not be confused and think they're not available in their release. We can drop the "React canary channel" part once we ship the pinned version for react 18, but it's probably better to keep it until the stable release so we don't churn external links.

React 19 callout and sidebar

Screenshot 2024-04-28 at 2 50 28 PM

React Server Component callout

Screenshot 2024-04-28 at 2 50 52 PM

Inline React 19 badges

Screenshot 2024-04-28 at 2 55 04 PM

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 2:26am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.16 KB (🟡 +77 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 81.47 KB (🟡 +1.26 KB) 185.63 KB
/500 81.46 KB (🟡 +1.26 KB) 185.63 KB
/[[...markdownPath]] 83.29 KB (🟡 +1.27 KB) 187.45 KB
/errors 81.68 KB (🟡 +1.26 KB) 185.84 KB
/errors/[errorCode] 81.65 KB (🟡 +1.26 KB) 185.81 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Collaborator

@noahlemen noahlemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! i'll update #6777 after this lands

Copy link
Collaborator

@jackpope jackpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@rickhanlonii rickhanlonii changed the base branch from main to v19 April 30, 2024 02:19
@rickhanlonii
Copy link
Member Author

rickhanlonii commented Apr 30, 2024

Changed the base to v19

@rickhanlonii rickhanlonii merged commit fda8424 into reactjs:v19 Apr 30, 2024
4 of 5 checks passed
@rickhanlonii rickhanlonii deleted the rh/19-beta branch April 30, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants