Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Update examples #1800

Closed
wants to merge 46 commits into from
Closed

(WIP) Update examples #1800

wants to merge 46 commits into from

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jun 11, 2016

Just letting everyone I decided to start working on updating all examples.
I’m starting with work @xulien did in #1403 and adding stuff on top.

There is no cohesive plan yet, but I want to:

  • Update versions of React, Redux, and React Router
  • Remove React Transform
  • Add some selectors instead of reading state directly
  • Use string literals instead of constants (at least, in simple examples)
  • Use more functional components
  • Add some comments
  • Add object spread transform
  • Whatever misc work I might decide to do

I have no idea how long it’s going to take (I’ll work on this in my free time). I’ll likely try to cherry-pick some tests in the open PRs, and use them here.

Replace universal example with async-with-routing and async-universal
@mxstbr
Copy link
Contributor

mxstbr commented Jun 14, 2016

Let me know if/when you have a cohesive plan, would love to jump in and help out!

@gaearon
Copy link
Contributor Author

gaearon commented Jun 14, 2016

@mxstbr I’d appreciate if you could update some of the other examples to the same build setup/convention I made in async example.

@mxstbr
Copy link
Contributor

mxstbr commented Jun 14, 2016

Updated the counter example in f7b5220 for a start! (everything works perfectly fine, inc. HMR and building) I'd appreciate a sanity check that everything is correctly before I go ahead and update some other ones.

Are there specific ones (like the universal one maybe?) that shouldn't be touched?

@timdorr
Copy link
Member

timdorr commented Aug 10, 2016

Looks like #1883 supercedes this work. Or at least the majority of the infrastructure changes. Let's close this for now, work through the create-react-app changes, and then do a new PR with any further updates after the dust settles with the tooling.

@timdorr timdorr closed this Aug 10, 2016
@gaearon
Copy link
Contributor Author

gaearon commented Aug 10, 2016

Yea. The funny thing is that not wanting to come back to this PR was one of the driving forces behind Create React App. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants