Use more ES6 syntaxes in the shopping cart example #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return (dispatch, getState) => { | ||
| const cart = getState().cart | ||
| export const checkout = (products) => (dispatch, getState) => { | ||
| const cart = getState().cart |
There was a problem hiding this comment.
If you're really going this far, you might as well do const {cart} = getState().
There was a problem hiding this comment.
Done. I agree, it was a total overkill before ;)
|
Thanks! |
gaearon
reviewed
Sep 18, 2016
| </div> | ||
| ) | ||
| } | ||
| return <div> |
There was a problem hiding this comment.
I strongly dislike this style. Can we please do a pass in a separate PR that ensures returned multilne JSX is always wrapped in parens? As in:
return (
<div>
...
</div>
)and
const Stuff = () => (
<div>
...
</div>
);
gaearon
reviewed
Sep 18, 2016
| export function getVisibleProducts(state) { | ||
| return state.visibleIds.map(id => getProduct(state, id)) | ||
| } | ||
| export const getVisibleProducts = state => state.visibleIds.map(id => |
There was a problem hiding this comment.
If the arrow body is multiline please always start the body on the next line.
Please make it like:
export const getVisibleProducts = state =>
...or
export const getVisibleProducts = state => (
...
)There was a problem hiding this comment.
Thanks for the styling advices, I'll do a pass on all of my PRs to conform with the comments you made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the shopping cart example files to using fat arrows, spread operators and stateless components.
References #1800