Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks reference #226

Merged
merged 34 commits into from Mar 15, 2019
Merged

Hooks reference #226

merged 34 commits into from Mar 15, 2019

Conversation

polling
Copy link
Contributor

@polling polling commented Mar 4, 2019

No description provided.

@polling polling mentioned this pull request Mar 4, 2019
Closed
88 tasks
@gcor gcor added the needs review A pull request ready to be reviewed label Mar 4, 2019
@netlify
Copy link

netlify bot commented Mar 4, 2019

Deploy preview for ru-reactjs ready!

Built with commit 2d75b9e

https://deploy-preview-226--ru-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 4, 2019 •
edited

Deploy preview for ru-reactjs ready!

Built with commit dc5a6e1

https://deploy-preview-226--ru-reactjs.netlify.com

ntishkevich
ntishkevich reviewed Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@ntishkevich ntishkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для первой итерации ревью достаточно будет изменений. Завтра постараюсь вычитать, очень много дословного перевода.
Также рекомендую ознакомиться с соглашением по переводу.

content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
@lex111 lex111 added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Mar 5, 2019
ntishkevich and others added 20 commits March 6, 2019 10:26
@ntishkevich @polling
Update content/docs/hooks-reference.md
e6291cd 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
524ad81 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
ca4e0af 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
857041a 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
9d04c55 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
ab78880 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
9c7e64a 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
2b50f89 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
2d696c0 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
df3350b 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
9b9bb9b 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
d005ce1 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
21ded51 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
32fe5cb 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
8da6641 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
025768b 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
ab725e8 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
083a917 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
868584e 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
6b6cc7a 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
ntishkevich and others added 7 commits March 6, 2019 10:42
@ntishkevich @polling
Update content/docs/hooks-reference.md
d1ed79b 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
465c5c8 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
ecd23b7 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
93d3ed2 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
1f296c5 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
aec7d41 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich @polling
Update content/docs/hooks-reference.md
808d1af 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@ntishkevich ntishkevich added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Mar 9, 2019
@ntishkevich @polling
Update content/docs/hooks-reference.md
ea5de01 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
lex111
lex111 reviewed Mar 10, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предложения для улучшения перевода.

content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
@gcor
Copy link
Collaborator

gcor commented Mar 10, 2019

рендеринг → рендер

gcor
gcor reviewed Mar 10, 2019
View reviewed changes
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
angryermine
angryermine reviewed Mar 11, 2019
View reviewed changes
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
another-guy
another-guy requested changes Mar 11, 2019
View reviewed changes
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated
>
> If you're migrating code from a class component, `useLayoutEffect` fires in the same phase as `componentDidMount` and `componentDidUpdate`, so if you're unsure of which effect Hook to use, it's probably the least risky.
> Если вы переносите код из компонента класса, `useLayoutEffect` запускается в той же фазе, что и `componentDidMount` и `componentDidUpdate`, поэтому, если вы не уверены, какой хук эффект использовать, это, вероятно, наименее рискованно.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Если вы переносите код из компонента класса, `useLayoutEffect` запускается в той же фазе, что и `componentDidMount` и `componentDidUpdate`, поэтому, если вы не уверены, какой хук эффект использовать, это, вероятно, наименее рискованно.
> Если вы переносите код из компонента класса, `useLayoutEffect` запускается на том же этапе, что и `componentDidMount` и `componentDidUpdate`, поэтому, если вы не уверены, какой хук эффект использовать, это, вероятно, наименее рискованно.

@ntishkevich ntishkevich added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Mar 11, 2019
@ntishkevich @polling
Update content/docs/hooks-reference.md
d9655ff 
Co-Authored-By: polling <sergey.bulatovich@gmail.com>
@another-guy
Copy link
Collaborator

@polling пожалуйста, рассмотрите/примите предложенные правки, если у вас есть возможность

@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Mar 15, 2019
@another-guy another-guy merged commit 064c273 into reactjs:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angryermine angryermine angryermine left review comments

@lex111 lex111 lex111 left review comments

@gcor gcor gcor left review comments

@ntishkevich ntishkevich ntishkevich left review comments

@another-guy another-guy another-guy approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@polling @gcor @another-guy @angryermine @lex111 @ntishkevich