Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate content/docs/addons-shallow-compare.md #361

Merged
merged 7 commits into from
Jul 27, 2019

Conversation

gcor
Copy link
Collaborator

@gcor gcor commented Jul 17, 2019

No description provided.

@netlify
Copy link

netlify bot commented Jul 17, 2019

Deploy preview for ru-reactjs ready!

Built with commit 35eed66

https://deploy-preview-361--ru-reactjs.netlify.com

@ntishkevich ntishkevich added the needs review A pull request ready to be reviewed label Jul 17, 2019
@ntishkevich
Copy link
Collaborator

Пулл реквест для ишью #350.
@gcor отличная работа!
Насколько я могу судить, версия переведенная в этом пулл реквесте отличается от оригинальной. В самой последней версии этой страницы упоминается React.memo. Можно проверить по ссылке https://ru.reactjs.org/docs/shallow-compare.html

Мне кажется, поэтому возник конфликт с мастером.

@gcor
Copy link
Collaborator Author

gcor commented Jul 17, 2019

Ага. Притянул последнее.

Copy link
Collaborator

@ntishkevich ntishkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несколько мелких вопросов по переводу, а так отличная работа! 💪

content/docs/addons-shallow-compare.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-compare.md Outdated Show resolved Hide resolved
gcor and others added 2 commits July 18, 2019 21:30
Co-Authored-By: Nick Tishkevich <Nikolai.Tishkevich@artezio.com>
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кое-что нашёл, что можно поправить + title нужно наверное перевести? Поверхностное сравнение?

content/docs/addons-shallow-compare.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-compare.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-compare.md Outdated Show resolved Hide resolved
gcor and others added 4 commits July 23, 2019 01:59
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
@gcor
Copy link
Collaborator Author

gcor commented Jul 23, 2019

title обновил

@gcor gcor merged commit ba81b5d into reactjs:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review A pull request ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants