Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): translate start a new react project #379

Merged
merged 2 commits into from
Apr 28, 2023
Merged

feat(docs): translate start a new react project #379

merged 2 commits into from
Apr 28, 2023

Conversation

neighborhood999
Copy link
Member

Signed-off-by: Jie Peng im@jiepeng.me

@neighborhood999
feat(docs): translate start a new react project
09221eb 
Signed-off-by: Jie Peng <im@jiepeng.me>
@neighborhood999 neighborhood999 mentioned this pull request Apr 27, 2023
Open
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

rayatn1011
rayatn1011 reviewed Apr 27, 2023
View reviewed changes
Copy link
Contributor

@rayatn1011 rayatn1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have refined some of the wording and corrected some errors. I hope you can consider them.

src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
@neighborhood999 neighborhood999 force-pushed the feat/start-a-new-react-project-tw branch from fba22ac to ba6ab81 Compare April 27, 2023 23:26
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@neighborhood999 neighborhood999 force-pushed the feat/start-a-new-react-project-tw branch from ba6ab81 to acc5f2c Compare April 27, 2023 23:30
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@neighborhood999
fix: wording
4700ec0 
Signed-off-by: Jie Peng <im@jiepeng.me>
@neighborhood999 neighborhood999 force-pushed the feat/start-a-new-react-project-tw branch from acc5f2c to 4700ec0 Compare April 27, 2023 23:36
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@neighborhood999
Copy link
Member Author

I have refined some of the wording and corrected some errors. I hope you can consider them.

Hi @rayatn1011, thank you for helping to review the translation, I applied most suggestions, and you can check it again.

@rayatn1011
Copy link
Contributor

I have refined some of the wording and corrected some errors. I hope you can consider them.

Hi @rayatn1011, thank you for helping to review the translation, I applied most suggestions, and you can check it again.

Hi @neighborhood999 , it seems better, thank you and nice job!

@neighborhood999 neighborhood999 merged commit eb1d398 into main Apr 28, 2023
@neighborhood999 neighborhood999 deleted the feat/start-a-new-react-project-tw branch April 28, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayatn1011 rayatn1011 rayatn1011 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neighborhood999 @rayatn1011