Build polish and upgrade, switch to Gradle 6.8.3, snapshot of 1.0.5

[simonbasle]

• Fix current snapshot 1.0.5 not 1.0.4 (Build polish and upgrade, switch to Gradle 6.8.3, snapshot of 1.0.5 #175)
• Build polish: remove jcenter() in favor of mavenCentral() (Build polish and upgrade, switch to Gradle 6.8.3, snapshot of 1.0.5 #175)
• Build polish: add simonbasle as dev (Build polish and upgrade, switch to Gradle 6.8.3, snapshot of 1.0.5 #175)
• Build polish: bump Gradle to 6.8.3 and fix build issues (Build polish and upgrade, switch to Gradle 6.8.3, snapshot of 1.0.5 #175)

[OlegDokuka]

LGTM but I would defer merging till @bsideup comments

[simonbasle]

NB: I have validated the current commit works by using jitpack in a demo project that installs the agent programmatically and flags a Thread.sleep.

[simonbasle]

I'll merge this for now, but don't hesitate to chime in @bsideup, your input will be appreciated 👍

[bsideup]

@simonbasle I am curious what was the motivation to merge this so fast, outside of work hours (19:30)?

Also, the branch name (buildPolishMarch2021) kinda suggests that the "normal" approach (1 PR per change) was ignored. Have you changed it and started doing monthly massive PRs? 😅

[bsideup]

JFYI I am no longer receiving the mention notifications, as I was force removed from the org, and I cannot change my notifications anymore (I had reactor org notifications configured to go to my Pivotal email)

[simonbasle]

@bsideup yeah I wanted to move quickly on this to get JDK 16 compatible snapshots (and fix the bad snapshot version). I could have done multiple PRs I guess, but I preferred these build-related changes to be reviewed together, as it didn't feel that massive.

re the notifications, have you tried removing your pivotal email from the github account altogether? that sounds like a github bug :(

[bsideup]

@simonbasle I cannot remove the email, I'd lose my contributions :D

AFAIK JDK 16 removed the flag that we were relying upon (AllowRedefinitionToAddDeleteMethods).
"JDK 16 compatible snapshots" may not be as easy as updating Gradle, and if I were you, I would start with adding JDK 16 to the test matrix ;)

[simonbasle]

It boils down to: I don't think there was actual harm in bumping these dependencies and Gradle, but I could have waited a tiny bit longer before merging. My bad.

AFAIK JDK 16 removed the flag that we were relying upon (AllowRedefinitionToAddDeleteMethods).
"JDK 16 compatible snapshots" may not be as easy as updating Gradle, and if I were you, I would start with adding JDK 16 to the test matrix ;)

Fair point. Let's not advertise JDK16 compatibility just yet, then 😞

Ping me on email if you need help from VMware side to resolve the notification issue.

[bsideup]

@simonbasle it's okay, these notifications are only for reactor org, all my other notifications go to my personal email.

Once BlockHound goes to the Reactive Foundation, it won't be a problem anymore.