Skip to content

Commit

Permalink
Remove compilation warnings related to jsr305
Browse files Browse the repository at this point in the history
  • Loading branch information
@ericbottard
ericbottard committed Jun 26, 2020
1 parent b8fbd7f commit 85da74b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions benchmarks/build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ configurations {
dependencies {
// Use the baseline to avoid using new APIs in the benchmarks
compileOnly "io.projectreactor:reactor-core:${perfBaselineVersion}"
compileOnly "com.google.code.findbugs:jsr305:${jsr305Version}"

implementation "org.openjdk.jmh:jmh-core:1.21"
implementation "io.projectreactor.addons:reactor-extra:3.3.3.RELEASE", {
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/io/reactor/gradle/JavaConventions.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ private void applyJavaConvention(Project project) {
"-Xlint:finally",
"-Xlint:overrides",
"-Xlint:path",
"-Xlint:processing",
"-Xlint:-processing",
"-Xlint:static",
"-Xlint:try",
"-Xlint:deprecation",
Expand Down
1 change: 1 addition & 0 deletions reactor-test/build.gradle
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ ext {

dependencies {
compile project(":reactor-core")
compileOnly "com.google.code.findbugs:jsr305:${jsr305Version}"

optional "org.jetbrains.kotlin:kotlin-stdlib:${kotlinVersion}"

Expand Down

3 comments on commit 85da74b

@simonbasle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericbottard in the absence of an associated issue, the commit title should have mentioned the PR number (and I generally try to prefix with a [build] or [polish] but that's only really relevant for the rare direct commits that we do without even a PR). this will help with automating the generation of release notes in the future. to keep in mind ;)

@ericbottard
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a chicken and egg problem then :).
The best thing to do is to create an issue, which I'll do.

@ericbottard
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dammit, didn't realize this was already merged. NVM

Please sign in to comment.