Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialized wrappers for SinkOne and Sink Empty #2410

Closed
aneveu opened this issue Sep 30, 2020 · 0 comments · Fixed by #2419
Closed

Add serialized wrappers for SinkOne and Sink Empty #2410

aneveu opened this issue Sep 30, 2020 · 0 comments · Fixed by #2419
Assignees
@aneveu
Labels
type/enhancement A general enhancement
Milestone
3.4.0-RC2

Comments

@aneveu
Copy link
Contributor

aneveu commented Sep 30, 2020

Similarly to what has been done for SinkMany, create serialized wrappers for SinkOne and SinkEmpty.
@reactorbot reactorbot added the ❓need-triage This issue needs triage, hasn't been looked at by a team member yet label Sep 30, 2020
@aneveu aneveu self-assigned this Sep 30, 2020
@simonbasle simonbasle added type/enhancement A general enhancement and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Oct 2, 2020
@simonbasle simonbasle added this to the 3.4.0-RC2 milestone Oct 2, 2020
@aneveu aneveu linked a pull request Oct 8, 2020 that will close this issue
fix #2410 Add serialized wrappers for Sinks.Empty/Sinks.One #2419
Merged
simonbasle pushed a commit that referenced this issue Oct 8, 2020
@aneveu
fix #2410 Add serialized wrappers for Sinks.Empty/Sinks.One
c9700ad 
This commit adds serializing wrapper implementations for Sinks.Empty
and Sinks.One, also extracting the `SerializedManySink` and renaming
it to `SinkManySerialized` (so that it is listed closer to `Sinks`).
@simonbasle simonbasle mentioned this issue Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aneveu aneveu

Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-RC2
Development

Successfully merging a pull request may close this issue.

fix #2410 Add serialized wrappers for Sinks.Empty/Sinks.One reactor/reactor-core
3 participants
@aneveu @simonbasle @reactorbot