-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide onDiscard support in UnicastProcessor #2102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
bugfix/unicast-discard
branch
from
April 5, 2020 18:36
7780fd1
to
ddc0270
Compare
Codecov Report
@@ Coverage Diff @@
## master #2102 +/- ##
============================================
+ Coverage 81.96% 82.02% +0.05%
Complexity 4091 4091
============================================
Files 380 380
Lines 31247 31246 -1
Branches 5800 5799 -1
============================================
+ Hits 25612 25628 +16
+ Misses 4061 4052 -9
+ Partials 1574 1566 -8 Continue to review full report at Codecov.
|
OlegDokuka
changed the title
Provides support for Queue elements discard on termination
Provides support for Apr 6, 2020
UnicastProcessor
to discard elements of it's Queue
on termination
simonbasle
approved these changes
Apr 6, 2020
simonbasle
added
area/doOnDiscard
This belongs to the doOnDiscard theme
type/enhancement
A general enhancement
labels
Apr 6, 2020
simonbasle
changed the title
Provides support for
Provide onDiscard support in UnicastProcessor
Apr 6, 2020
UnicastProcessor
to discard elements of it's Queue
on termination
@OlegDokuka this one should actually be backported in 3.2.x 😨 |
simonbasle
added a commit
that referenced
this pull request
Apr 20, 2020
simonbasle
added a commit
that referenced
this pull request
Apr 21, 2020
simonbasle
added a commit
that referenced
this pull request
Apr 22, 2020
simonbasle
added a commit
that referenced
this pull request
Apr 22, 2020
simonbasle
added a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when UnicastProcessor is canceled all the elements are safely discarded so no leaks are going to appear
Signed-off-by: Oleh Dokuka shadowgun@i.ua