fix #2124 Backport and improve discard handling in UnicastProcessor #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
force-pushed
the
2124-fixLeaksInUnicastProcessor
branch
from
9804663
to
2fc5796
Compare
simonbasle
force-pushed
the
2124-fixLeaksInUnicastProcessor
branch
from
2fc5796
to
586a9c1
Compare
simonbasle
added a commit
that referenced
this pull request
Apr 22, 2020
This is a follow-up to #2125, this time targeting the same class of discarding race but on `UnicastProcessor`. As there is a chance that the race references `actual` (to resolve the discard hook) AFTER `cancel()`, we need to keep that field populated. It was nulled out for the benefit of `downstreamCount()` (see #980) so we replace that by a boolean, set to true when subscribed. Reviewed-in: #2126
simonbasle
force-pushed
the
2124-fixLeaksInUnicastProcessor
branch
from
586a9c1
to
9a76624
Compare
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
Apr 22, 2020
simonbasle
added a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently drafted as it depends on Provides tests suite to expose onDiscard leaks and fixes #2125, which is still WIP