Polish Signal based operators #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smaldini
commented
Aug 3, 2017
smaldini
commented
- Turn Signal into interface
- Remove MutableNextSignal
- Precise FluxPeekStateful to FluxDoOnEach
43 tasks
- Turn Signal into interface - Remove MutableNextSignal - Precise FluxPeekStateful to FluxDoOnEach
smaldini
force-pushed
the
polish-signal-operator
branch
from
3e614f9
to
59de1d3
Compare
simonbasle
requested changes
Aug 4, 2017
| @@ -69,4 +70,72 @@ public SignalType getType() { | |||
| return type; | |||
| } | |||
|
|
|||
| //the base class defines equals and hashcode as final in order to allow | |||
|
|
|||
There was a problem hiding this comment.
equals is not final and this is not a base class anymore, so remove broken comment ;)
| } | ||
| return false; | ||
| } | ||
| //to implement additional state. |
There was a problem hiding this comment.
that was part of the comment of equals, remove it too
|
The rationale is simply shrinking surface API when possible due to its specificity and simplicity to reproduce. Also the operator was only used by doOnEach and if we happen to implement a doOnNext with state we'll revisit. In fact this operator should also be used by ParallelFlux too and eventually be fuseable. |
|
Also DoOnEachSubscriber implement Signal directly to avoid allocations. |
simonbasle
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.