Cleanup deprecations and warnings #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
added
the
type/chore
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
============================================
+ Coverage 80.39% 80.60% +0.21%
Complexity 241 241
============================================
Files 22 22
Lines 1015 1021 +6
Branches 91 91
============================================
+ Hits 816 823 +7
- Misses 165 166 +1
+ Partials 34 32 -2
Continue to review full report at Codecov.
|
simonbasle
reviewed
Jun 22, 2020
| @@ -196,7 +197,7 @@ public void subscribe(CoreSubscriber<? super Object> s) { | |||
| .then(); | |||
| } | |||
|
|
|||
| private <T> Flux<SenderResult<T>> transaction(Publisher<? extends SenderRecord<K, V, T>> transactionRecords, UnicastProcessor<Object> transactionBoundary) { | |||
| private <T> Flux<SenderResult<T>> transaction(Publisher<? extends SenderRecord<K, V, T>> transactionRecords, FluxIdentityProcessor<Object> transactionBoundary) { | |||
There was a problem hiding this comment.
is the transactionBoundary really useful? the concatWith(Mono.create) a few line below is also very strange
There was a problem hiding this comment.
yes, I was also WTFing at concatMap(Mono.create(, but didn't want to touch/change the current logic.
FTR "Sender" refactoring is planned for M2 (while "Receiver" was a target for M1), where I will cleanup it anyways
simonbasle
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.