kafka-clients 3.0.0 Compatibility #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming 3.0.0 release adds a new method to `Consumer` and removes a deprecated one from `ConsumerRecord`. Use reflection for these two methods to enable reactor-kafka to be used with the older clients as well as 3.0.0 when used in other projects, such as Spring for Apache Kafka.
artembilan
requested changes
Sep 7, 2021
| import java.util.concurrent.TimeUnit; | ||
| import java.util.concurrent.atomic.AtomicLong; | ||
| import java.util.concurrent.locks.ReentrantLock; | ||
| import java.util.regex.Pattern; |
There was a problem hiding this comment.
Is this Project Reactor code style to have Java imports in the end?
There was a problem hiding this comment.
Yes; this class was not consistent.
| // Consumer delegate = mock(Consumer.class); | ||
| // ConsumerDelegate consumer = new ConsumerDelegate(delegate); | ||
| // given(delegate.currentLag(any())).willReturn(OptionalLong.of(42L)); | ||
| // assertEquals(42L, consumer.currentLag(new TopicPartition("foo", 0)).getAsLong()); |
There was a problem hiding this comment.
Are you going to finish this test?
There was a problem hiding this comment.
It requires the 3.0.0 client on the classpath - I used it to test with that client - commented out for older clients.
artembilan
approved these changes
Sep 7, 2021
simonbasle
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
sorry this one fell through the cracks. lgtm, and I'll also defer to @artembilan review 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming 3.0.0 release adds a new method to
Consumerand removesa deprecated one from
ConsumerRecord.Use reflection for these two methods to enable reactor-kafka to be used
with the older clients as well as 3.0.0 when used in other projects, such
as Spring for Apache Kafka.