Skip to content

Commit

Permalink
Fix Authors attribute (#3214)
Browse files Browse the repository at this point in the history
Currently, authors are declared in two places:

in docs/modules/ROOT/pages/about-doc.adoc: authors are declared in the Multiple authors line, in the start page (about-adoc.adoc). Authors are then displayed when browsing antora documentation (in the start page).

in antora.yml, using an author attribute: this was attempt to make the authors also appearing in the front page of the generated pdf.

But the authors are not currently included in the front page of the PDF.

this PR moves the author attribute from the antora attributes to the asciidoc attributes in the antora.yml, and this fixes the problem: authors are now displayed in the front page of the generated PDF.
  • Loading branch information
pderop committed Apr 30, 2024
1 parent 1c65384 commit cbc8a5d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/antora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ name: reactor-netty
version: true
title: Reactor Netty Reference Guide
start_page: about-doc.adoc
author:
- Stephane Maldini <https://twitter.com/smaldini[@smaldini]>
- Violeta Georgieva <https://twitter.com/violeta_g_g[@violeta_g_g]>
nav:
- modules/ROOT/nav.adoc
ext:
Expand All @@ -28,3 +25,6 @@ asciidoc:
http-source-link: '{reactor-netty-github-repo}/reactor-netty-http/src/main/java'
javadoc: 'https://projectreactor.io/docs/netty/{project-version}/api'
nettyjavadoc: 'https://netty.io/4.1/api'
author:
- Stephane Maldini
- Violeta Georgieva

0 comments on commit cbc8a5d

Please sign in to comment.