Fix Authors attribute #3214
Merged
Fix Authors attribute #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the PR:
|
violetagg
approved these changes
Apr 30, 2024
|
@violetagg , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, authors are declared in two places:
in docs/modules/ROOT/pages/about-doc.adoc: authors are declared in the Multiple authors line, in the start page (about-adoc.adoc). Authors are then displayed when browsing antora documentation (in the start page).
in antora.yml, using an author attribute: this was attempt to make the authors also appearing in the front page of the generated pdf.
But the authors are not currently included in the front page of the PDF.
this PR moves the author attribute from the antora attributes to the asciidoc attributes in the antora.yml, and this fixes the problem: authors are now displayed in the front page of the generated PDF.