Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpServerOptions compression threshold is ignored, always compressing #106

Closed
simonbasle opened this issue Jun 20, 2017 · 0 comments
Closed

HttpServerOptions compression threshold is ignored, always compressing #106

simonbasle opened this issue Jun 20, 2017 · 0 comments
Assignees
@simonbasle
Labels
type/bug A general bug
Milestone
0.7.0.M1

Comments

@simonbasle
Copy link
Member

Setting HttpServerOptions.compression(123) is the same as compression(true) due to the parameter being ignored.

Additionally, this is not surfaced by the tests because they use a client with the compression(true) option, which introduces a handler that will decode gzip data and remove the gzip header.

Fixing the test serverCompressionEnabledSmallResponse (and others) to manually trigger compression via client request header rather than the option/codec surfaces the problem.
@simonbasle simonbasle added the type/bug A general bug label Jun 20, 2017
@simonbasle simonbasle added this to the 0.7.0.M1 milestone Jun 20, 2017
@simonbasle simonbasle self-assigned this Jun 20, 2017
simonbasle added a commit that referenced this issue Jun 20, 2017
@simonbasle
fix #106 Take HttpServerOptions.compression(int) threshold into account
4bf1b68 
Rework the tests so that they correctly surface the issue, fix the
option ignoring the threshold and always activating compression.
simonbasle added a commit that referenced this issue Jun 20, 2017
@simonbasle
fix #106 Take HttpServerOptions.compression(int) threshold into account
567d51c 
Rework the tests so that they correctly surface the issue, fix the
option ignoring the threshold and always activating compression.
@simonbasle simonbasle mentioned this issue Jun 20, 2017
Merged
utwyko pushed a commit to utwyko/reactor-netty that referenced this issue Jul 6, 2017
@simonbasle
fix reactor#106 Take HttpServerOptions.compression(int) threshold int…
dd855de 
…o account

Rework the tests so that they correctly surface the issue, fix the
option ignoring the threshold and always activating compression.
@smaldini smaldini mentioned this issue Feb 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
type/bug A general bug
Projects
None yet
Milestone
0.7.0.M1
Development

No branches or pull requests
1 participant
@simonbasle