Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocked appender are never removed from Logger in ReactorNettyLoggingHandlerTest #1422

Closed
aneveu opened this issue Dec 11, 2020 · 0 comments · Fixed by #1429
Closed

Mocked appender are never removed from Logger in ReactorNettyLoggingHandlerTest #1422

aneveu opened this issue Dec 11, 2020 · 0 comments · Fixed by #1429
Assignees
@aneveu
Labels
type/bug A general bug
Milestone
1.0.3

Comments

@aneveu
Copy link
Contributor

aneveu commented Dec 11, 2020 •
edited

Mocked appender declared into setup method, which is called with @beforeEach, are never removed from the root Loggerinto ReactorNettyLoggingHandlerTest.

Possible Solution

Remove mocked appenders created in each method from logger into a teardown method, annotated with@afterEach.
@aneveu aneveu added type/bug A general bug status/need-triage A new issue that still need to be evaluated as a whole labels Dec 11, 2020
@violetagg violetagg added this to the 1.0.3 milestone Dec 11, 2020
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Dec 11, 2020
aneveu pushed a commit that referenced this issue Dec 14, 2020
Fix #1422 Remove mocked appender from root logger after each test in …
2ecb068 
…ReactorNettyLoggingHandlerTest
@violetagg violetagg linked a pull request Dec 14, 2020 that will close this issue
Fix #1422 Remove appender from logger after each test in ReactorNettyLoggingHandlerTest #1429
Merged
aneveu added a commit that referenced this issue Dec 15, 2020
@aneveu
Fix #1422 Remove appender from logger after each test in ReactorNetty…
380a10a 
…LoggingHandlerTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aneveu aneveu

Labels
type/bug A general bug
Projects
None yet
Milestone
1.0.3
2 participants
@aneveu @violetagg