Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1422 Remove appender from logger after each test in ReactorNettyLoggingHandlerTest #1429

Merged

Conversation

aneveu
Copy link
Contributor

@aneveu aneveu commented Dec 14, 2020

No description provided.

@violetagg violetagg added this to the 1.0.3 milestone Dec 14, 2020
@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #1429 (a2a7580) into master (db46d31) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1429      +/-   ##
============================================
+ Coverage     70.77%   70.82%   +0.05%     
- Complexity     1855     1858       +3     
============================================
  Files           145      145              
  Lines          9194     9194              
  Branches       1256     1256              
============================================
+ Hits           6507     6512       +5     
+ Misses         2033     2026       -7     
- Partials        654      656       +2     
Impacted Files Coverage Δ Complexity Δ
.../main/java/reactor/netty/channel/MonoSendMany.java 60.25% <0.00%> (-0.64%) 12.00% <0.00%> (ø%)
...eactor/netty/http/server/HttpServerOperations.java 74.55% <0.00%> (+0.35%) 75.00% <0.00%> (+1.00%)
...c/main/java/reactor/netty/channel/FluxReceive.java 67.42% <0.00%> (+1.35%) 54.00% <0.00%> (+1.00%)
.../reactor/netty/http/server/HttpTrafficHandler.java 81.77% <0.00%> (+1.40%) 56.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46d31...48ccef3. Read the comment docs.

@aneveu aneveu force-pushed the 1422-RemoveAppenderAfterTestInReactorNettyLoggingHandlerTest branch from a2a7580 to f1004e8 Compare December 14, 2020 15:16
@aneveu aneveu force-pushed the 1422-RemoveAppenderAfterTestInReactorNettyLoggingHandlerTest branch from f1004e8 to 48ccef3 Compare December 14, 2020 15:26
@aneveu aneveu merged commit 380a10a into master Dec 15, 2020
@aneveu aneveu deleted the 1422-RemoveAppenderAfterTestInReactorNettyLoggingHandlerTest branch December 15, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocked appender are never removed from Logger in ReactorNettyLoggingHandlerTest
3 participants