Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling the mono from NettyOutbound.send(Publisher) has no effect #317

Closed
smaldini opened this issue Apr 8, 2018 · 0 comments
Closed

Cancelling the mono from NettyOutbound.send(Publisher) has no effect #317

smaldini opened this issue Apr 8, 2018 · 0 comments
Labels
type/enhancement A general enhancement
Milestone
0.7.7.RELEASE

Comments

@smaldini
Copy link
Contributor

smaldini commented Apr 8, 2018

While working with @nebhale we realized that the returned mono does not translate cancellation.
It should propagate the cancel to the passed publisher to prevent further writes and also cleanup the state in ChannelOperationHandler.
@smaldini smaldini added the type/enhancement A general enhancement label Apr 8, 2018
@smaldini smaldini added this to the 0.7.7.RELEASE milestone Apr 8, 2018
@smaldini smaldini mentioned this issue Apr 21, 2018
Closed
@violetagg violetagg reopened this Apr 24, 2018
smaldini added a commit that referenced this issue Apr 25, 2018
@smaldini
Fix #317 Forward user-facing cancel to send(Publisher) cancel (#335)
79fe5b6 
Fix #317 Forward user-facing cancel to send(Publisher) cancel
Reduce instance allocations for send(Publisher) with context.
Fix possible listener leak in FutureMono for immediately cancelling subscription.

Will not not propagate cancel to future (to be deprecated anyway in Netty 5)
fix context propagation optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
0.7.7.RELEASE
Development

No branches or pull requests
2 participants
@smaldini @violetagg