Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317 Forward user-facing cancel to send(Publisher) cancel #335

Merged
merged 2 commits into from Apr 25, 2018

Conversation

smaldini
Copy link
Contributor

@smaldini smaldini commented Apr 24, 2018

Reduce instance allocations for send(Publisher).
Optimize context passing.
Possible Fix for FutureSubscription onSubscribe and addListener ordering (possible listener leak)

Stephane Maldini added 2 commits April 25, 2018 14:08
Reduce instance allocations for send(Publisher)
@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #335 into master will increase coverage by 0.12%.
The diff coverage is 75.7%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
+ Coverage     68.51%   68.64%   +0.12%     
+ Complexity     1028     1027       -1     
============================================
  Files            73       72       -1     
  Lines          4316     4391      +75     
  Branches        614      624      +10     
============================================
+ Hits           2957     3014      +57     
- Misses          989     1001      +12     
- Partials        370      376       +6
Impacted Files Coverage Δ Complexity Δ
src/main/java/reactor/ipc/netty/NettyOutbound.java 84.21% <100%> (-0.54%) 26 <3> (-1)
...or/ipc/netty/channel/ChannelOperationsHandler.java 67.03% <62.5%> (+3.06%) 59 <0> (ø) ⬇️
src/main/java/reactor/ipc/netty/FutureMono.java 70.83% <75.67%> (-11.17%) 9 <5> (+4)
src/main/java/reactor/ipc/netty/ReactorNetty.java 77.34% <85.71%> (+1.02%) 22 <3> (+3) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 63.02% <0%> (-5.05%) 25% <0%> (-2%)
...or/ipc/netty/http/client/HttpClientOperations.java 57.1% <0%> (-0.27%) 79% <0%> (-1%)
...ctor/ipc/netty/resources/DefaultPoolResources.java 79.31% <0%> (+3.44%) 9% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9275373...9a45ab3. Read the comment docs.

@smaldini smaldini added this to the 0.7.7.RELEASE milestone Apr 25, 2018
@smaldini smaldini merged commit 79fe5b6 into master Apr 25, 2018
@smaldini smaldini added the type/enhancement A general enhancement label Apr 25, 2018
@smaldini smaldini deleted the 317-propagateSendCancel branch April 25, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants