Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Logs contents enhancement #434

Closed
ErwanLetessier opened this issue Sep 17, 2018 · 1 comment
Closed

Access Logs contents enhancement #434

ErwanLetessier opened this issue Sep 17, 2018 · 1 comment
Labels
type/enhancement A general enhancement

Comments

@ErwanLetessier
Copy link

#301 lately brought support of access logs.
I would need a couple of more information in those logs:

  • request port
  • time taken (in milliseconds)

Furthermore, I don't get the point in having the date time with force formatting in the logged message while the logger will add it with user-configured format.

ErwanLetessier pushed a commit to ErwanLetessier/reactor-netty that referenced this issue Sep 17, 2018
Add request port to the log message.
Add duration in milliseconds between request and response.
ErwanLetessier pushed a commit to ErwanLetessier/reactor-netty that referenced this issue Sep 17, 2018
Add request port to the log message.
Add duration in milliseconds between request and response.
@violetagg
Copy link
Member

Furthermore, I don't get the point in having the date time with force formatting in the logged message while the logger will add it with user-configured format.

With the first implementation we support CLF, so we use the specified date format.
When you use this log configuration https://github.com/reactor/reactor-netty/blob/master/src/test/resources/logback.xml#L35 you will receive exactly CLF.

I created another enhancement #436 so that we provide more options for the access log.

@violetagg violetagg added this to the 0.7.10.RELEASE milestone Sep 17, 2018
@violetagg violetagg added the type/enhancement A general enhancement label Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants