Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more options for customising the access log #436

Closed
violetagg opened this issue Sep 17, 2018 · 9 comments
Closed

Provide more options for customising the access log #436

violetagg opened this issue Sep 17, 2018 · 9 comments
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Milestone
1.0.1

Comments

@violetagg
Copy link
Member

No description provided.

@violetagg violetagg added the type/enhancement A general enhancement label Sep 17, 2018
@violetagg violetagg added this to the 0.8.x Backlog milestone Sep 17, 2018
@violetagg violetagg mentioned this issue Sep 17, 2018
Closed
@violetagg violetagg added the good first issue Ideal for a new contributor, we'll help label Oct 7, 2018
@hota911 hota911 mentioned this issue Oct 25, 2018
Closed
@smaldini smaldini modified the milestones: 0.8.x Backlog, 0.9.x Backlog Feb 7, 2019
@jkubrynski
Copy link

Is there any idea of this customization? Should it be on a code-level or just a string format parsed by the AccessLog ?

@sonofelice
Copy link

I also have the same problem. I want to add some info from httpServeletRequest, like the access log of tomcat.How can I customize the log format?

@sonofelice
Copy link

Is there any progress here?

@jkubrynski
Copy link

I offered a PR, but there is no decision on how this customization should look like. Programmatic or string pattern

@sonofelice
Copy link

I offered a PR, but there is no decision on how this customization should look like. Programmatic or string pattern

I did not find your pr link. Would you like put the link here?

@violetagg violetagg mentioned this issue Jul 2, 2019
Closed
@naturallight
Copy link

Is there any update?

@violetagg violetagg modified the milestones: 0.9.x Maintenance Backlog, 1.0.0 Backlog May 11, 2020
@ek-ex
Copy link

ek-ex commented Jun 23, 2020

Could you also include the request headers to this enhancement ? Thank you

@violetagg violetagg mentioned this issue Aug 12, 2020
Closed
@violetagg violetagg mentioned this issue Oct 29, 2020
Closed
@violetagg
Copy link
Member Author

This issue is currently discussed in #1357
Any feedback is more than welcome

@violetagg violetagg modified the milestones: 1.0.0 Backlog, 1.0.1 Oct 30, 2020
@violetagg violetagg linked a pull request Nov 3, 2020 that will close this issue
Provide customized access log #1357
Closed
violetagg pushed a commit that referenced this issue Nov 5, 2020
@violetagg
Provide customised access log (#1357)
9e44b6d 
Related to #436 and #476
@violetagg
Copy link
Member Author

Fixed with #1357

@ctlove0523 ctlove0523 mentioned this issue Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

Provide customized access log immuthex/reactor-netty
6 participants
@smaldini @violetagg @jkubrynski @naturallight @ek-ex @sonofelice