Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection pool should default to a fixed size #578

Closed
smaldini opened this issue Jan 15, 2019 · 1 comment
Closed

Connection pool should default to a fixed size #578

smaldini opened this issue Jan 15, 2019 · 1 comment
Labels
type/enhancement A general enhancement warn/behavior-change Breaking change of publicly advertised behavior
Milestone
0.9.0.RC1

Comments

@smaldini
Copy link
Contributor

Currently Connection Pooling uses elastic (unbounded) default value. Local VM might struggle with this default, we should investigate whether this is a correct default to assume or if we limits should be given and tuning documented.
@smaldini smaldini added type/enhancement A general enhancement status/need-decision This needs team attention and discussion labels Jan 15, 2019
@smaldini smaldini added this to the 0.8.5.RELEASE milestone Jan 15, 2019
@smaldini smaldini mentioned this issue Jan 15, 2019
Closed
@smaldini smaldini modified the milestones: 0.8.5.RELEASE, 0.9.0.RELEASE Feb 7, 2019
@violetagg violetagg modified the milestones: 0.9.0.RELEASE, 0.9.0.M4 Aug 5, 2019
@violetagg violetagg removed the status/need-decision This needs team attention and discussion label Aug 5, 2019
@smaldini smaldini mentioned this issue Aug 6, 2019
Closed
@violetagg violetagg added the warn/behavior-change Breaking change of publicly advertised behavior label Aug 7, 2019
violetagg added a commit that referenced this issue Aug 7, 2019
@violetagg
fix #578 Switch "fixed" connection pool by default for TCP/HTTP client
3677955
@rstoyanchev rstoyanchev changed the title Default back connection pool to a fixed limit (e.g. 1000) Connection pool should default to a fixed size Jan 24, 2020
@rstoyanchev
Copy link
Contributor

rstoyanchev commented Jan 24, 2020 •
edited
Loading

TcpResources now defaults to 500 max connections (per host). The number of pending to acquire connections is currently not limited, but the acquire will fail within 45 secs of waiting.

For 1.0 the queue size for pending to acquire will also be limited, see #951 (comment).

@rstoyanchev rstoyanchev mentioned this issue Jan 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement warn/behavior-change Breaking change of publicly advertised behavior
Projects
None yet
Milestone
0.9.0.RC1
Development

No branches or pull requests
3 participants
@smaldini @rstoyanchev @violetagg