Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose read-only version of HttpServerOptions in HttpServer #66

Closed
mbhave opened this issue Mar 27, 2017 · 2 comments
Closed

Expose read-only version of HttpServerOptions in HttpServer #66

mbhave opened this issue Mar 27, 2017 · 2 comments
Assignees
@simonbasle
Labels
type/enhancement A general enhancement
Milestone
0.7.0.M1

Comments

@mbhave
Copy link

mbhave commented Mar 27, 2017 •
edited
Loading

Currently, when the server startup fails, we don't have access to the port that was used to start the server. We would like to log the failure along with the port (in case of a BindException).

/cc @bclozel
@mbhave mbhave mentioned this issue Mar 27, 2017
Closed
@rstoyanchev
Copy link
Contributor

There is a way to obtain the port (see #58).

@bclozel
Copy link
Member

bclozel commented Mar 27, 2017

@rstoyanchev In that case, we never get back the context since the BindException is thrown before the Mono is completed (we get an error signal instead).

@smaldini smaldini modified the milestone: 0.6.3.RELEASE Apr 7, 2017
@smaldini smaldini added the type/enhancement A general enhancement label May 3, 2017
@smaldini smaldini modified the milestones: 0.6.3.RELEASE, 0.7.0.RELEASE May 3, 2017
@simonbasle simonbasle modified the milestones: 0.7.0.RELEASE, 0.7.0.M1 Jun 19, 2017
@simonbasle simonbasle self-assigned this Jun 19, 2017
simonbasle added a commit that referenced this issue Jun 20, 2017
@simonbasle
fix #66 Expose duplicate of options for TCP/HTTP Client and Server
7993765 
This is useful when the handler cannot be created, to get the original
configuration of the Client/Server object.

The toString() methods for Client/Servers and Options have been aligned,
and each option type has 2 additional String representations (one
detailed as used in toString, the other simplified, as used by the
client/server's toString).
simonbasle added a commit that referenced this issue Jun 20, 2017
@simonbasle
fix #66 Expose duplicate of options for TCP/HTTP Client and Server
d68685d 
This is useful when the handler cannot be created, to get the original
configuration of the Client/Server object.

The toString() methods for Client/Servers and Options have been aligned,
and each option type has 2 additional String representations (one
detailed as used in toString, the other simplified, as used by the
client/server's toString).
simonbasle added a commit that referenced this issue Jun 21, 2017
@simonbasle
fix #66 Expose duplicate of options for TCP/HTTP Client and Server
c7860e0 
This is useful when the handler cannot be created, to get the original
configuration of the Client/Server object.

The toString() methods for Client/Servers and Options have been aligned,
and each option type has 2 additional String representations (one
detailed as used in toString, the other simplified, as used by the
client/server's toString).
utwyko pushed a commit to utwyko/reactor-netty that referenced this issue Jul 6, 2017
@simonbasle
fix reactor#66 Expose duplicate of options for TCP/HTTP Client and Se…
28b09a2 
…rver

This is useful when the handler cannot be created, to get the original
configuration of the Client/Server object.

The toString() methods for Client/Servers and Options have been aligned,
and each option type has 2 additional String representations (one
detailed as used in toString, the other simplified, as used by the
client/server's toString).
@bclozel bclozel mentioned this issue Jun 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
0.7.0.M1
Development

No branches or pull requests
5 participants
@smaldini @bclozel @rstoyanchev @mbhave @simonbasle