Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt ByteBufAllocatorMetrics to Buffer API #2363

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Adapt ByteBufAllocatorMetrics to Buffer API #2363

merged 1 commit into from
Jul 7, 2022

Conversation

violetagg
Copy link
Member

Fixes #2341

@violetagg violetagg added the type/enhancement A general enhancement label Jul 7, 2022
@violetagg violetagg added this to the 2.0.0-M1 milestone Jul 7, 2022
@violetagg violetagg requested a review from a team July 7, 2022 16:00
@violetagg violetagg linked an issue Jul 7, 2022 that may be closed by this pull request
Adapt ByteBufAllocatorMetrics to Buffer API #2341
Closed
pderop
pderop approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

The failed tests on CI are not related to this change.

@violetagg
Copy link
Member Author

@pderop Thanks for the review!

@violetagg violetagg merged commit 3a10231 into netty5 Jul 7, 2022
@violetagg violetagg deleted the metrics branch July 7, 2022 16:36
@violetagg
Copy link
Member Author

Related to #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.

Adapt ByteBufAllocatorMetrics to Buffer API
2 participants
@violetagg @pderop