Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt ByteBufAllocatorMetrics to Buffer API #2341

Closed
violetagg opened this issue Jun 29, 2022 · 0 comments · Fixed by #2363
Closed

Adapt ByteBufAllocatorMetrics to Buffer API #2341

violetagg opened this issue Jun 29, 2022 · 0 comments · Fixed by #2363
Assignees
@violetagg
Labels
type/enhancement A general enhancement
Milestone
2.0.0-M1

Comments

@violetagg
Copy link
Member

violetagg commented Jun 29, 2022 •
edited

The current implementation is temporary excluded with #2342
@violetagg violetagg added the type/enhancement A general enhancement label Jun 29, 2022
@violetagg violetagg added this to the 2.0.x Backlog milestone Jun 29, 2022
violetagg added a commit that referenced this issue Jun 29, 2022
@violetagg
Adapt to the changes in Netty 5 API
62e20e2 
- `@Sharable` is removed netty/netty#12522
- `ByteToMessageDecoderForBuffer` is renamed to `ByteToMessageDecoder` netty/netty#12512
- `ByteBuf` adapters are moved to Netty Contrib netty/netty#12512
- Enable `ObservabilitySmokeTest` netty/netty#12518
- `ByteBufAllocatorMetrics` functionality needs migration #2341
- Adapt CI build

Related to #1873
@violetagg violetagg mentioned this issue Jun 29, 2022
Merged
violetagg added a commit that referenced this issue Jun 29, 2022
@violetagg
Adapt to the changes in Netty 5 API (#2342)
0918511 
- `@Sharable` is removed netty/netty#12522
- `ByteToMessageDecoderForBuffer` is renamed to `ByteToMessageDecoder` netty/netty#12512
- `ByteBuf` adapters are moved to Netty Contrib netty/netty#12512
- Enable `ObservabilitySmokeTest` netty/netty#12518
- `ByteBufAllocatorMetrics` functionality needs migration #2341
- Adapt CI build

Related to #1873
@violetagg violetagg self-assigned this Jul 2, 2022
@violetagg violetagg modified the milestones: 2.0.x Backlog, 2.0.0-M1 Jul 6, 2022
violetagg added a commit that referenced this issue Jul 7, 2022
@violetagg
Adapt ByteBufAllocatorMetrics to Buffer API
404d5e7 
Fixes #2341
violetagg added a commit that referenced this issue Jul 7, 2022
@violetagg
Adapt ByteBufAllocatorMetrics to Buffer API
4208e16 
Fixes #2341
@violetagg violetagg mentioned this issue Jul 7, 2022
Merged
@violetagg violetagg linked a pull request Jul 7, 2022 that will close this issue
Adapt ByteBufAllocatorMetrics to Buffer API #2363
Merged
violetagg added a commit that referenced this issue Jul 7, 2022
@violetagg
Adapt ByteBufAllocatorMetrics to Buffer API (#2363)
3a10231 
Fixes #2341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetagg violetagg

Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging a pull request may close this issue.

Adapt ByteBufAllocatorMetrics to Buffer API reactor/reactor-netty
1 participant
@violetagg