Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new GitHub Actions API for setting output #2635

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Use new GitHub Actions API for setting output #2635

merged 1 commit into from
Jan 6, 2023

Conversation

violetagg
Copy link
Member

Related to reactor/reactor#727

@violetagg violetagg added the type/chore A task not related to code (build, formatting, process, ...) label Jan 6, 2023
@violetagg violetagg added this to the 1.0.27 milestone Jan 6, 2023
@violetagg violetagg requested a review from a team January 6, 2023 13:57
@violetagg violetagg mentioned this pull request Jan 6, 2023
Closed
@violetagg violetagg changed the title [chore] Use new GHA API for setting output Use new GitHub Actions API for setting output Jan 6, 2023
pderop
pderop approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; I see some errors, but likely that they are unrelated ?

@violetagg
Copy link
Member Author

lgtm; I see some errors, but likely that they are unrelated ?

yep the change is in the GHA not in the code so the failing tests can be ignored.

@violetagg violetagg merged commit 823ae04 into 1.0.x Jan 6, 2023
@violetagg violetagg deleted the gha-deprecated-functionality branch January 6, 2023 14:36
violetagg added a commit that referenced this pull request Jan 6, 2023
@violetagg
Merge #2635 into 1.1.2
866f78f
violetagg added a commit that referenced this pull request Jan 6, 2023
@violetagg
Merge #2635 into 2.0.0-M4
c069e28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Milestone
1.0.27
Development

Successfully merging this pull request may close these issues.
2 participants
@violetagg @pderop