When in graceful shutdown, send GO_AWAY to notify the client to stop opening streams
#2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure Http2FrameCodec with indefinite graceful shutdown timeout as the scheduling happens with ServerTransport#disposeNow https://datatracker.ietf.org/doc/html/rfc9113#GOAWAY "The GOAWAY frame (type=0x07) is used to initiate shutdown of a connection... GOAWAY allows an endpoint to gracefully stop accepting new streams while still finishing processing of previously established streams." "Once the GOAWAY is sent, the sender will ignore frames sent on streams initiated by the receiver if the stream has an identifier higher than the included last stream identifier. Receivers of a GOAWAY frame MUST NOT open additional streams on the connection..." "A GOAWAY frame might not immediately precede closing of the connection" "Activity on streams numbered lower than or equal to the last stream identifier might still complete successfully. The sender of a GOAWAY frame might gracefully shut down a connection by sending a GOAWAY frame, maintaining the connection in an "open" state until all in-progress streams complete." Fix #2735
violetagg
changed the title
GO_AWAY to notify the clientGO_AWAY to notify the client to stop opening streams
violetagg
added a commit
that referenced
this pull request
Apr 5, 2023
violetagg
added a commit
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure
Http2FrameCodecwith indefinite graceful shutdown timeout as the scheduling happens withServerTransport#disposeNowhttps://datatracker.ietf.org/doc/html/rfc9113#GOAWAY
Fix #2735