Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When in graceful shutdown, send GO_AWAY to notify the client to stop opening streams #2758

Merged
merged 1 commit into from
Apr 5, 2023

Commits on Mar 31, 2023

  1. When in graceful shutdown, send GO_AWAY to notify the client

    Configure Http2FrameCodec with indefinite graceful shutdown timeout
    as the scheduling happens with ServerTransport#disposeNow
    
    https://datatracker.ietf.org/doc/html/rfc9113#GOAWAY
    
    "The GOAWAY frame (type=0x07) is used to initiate shutdown of a connection...
    GOAWAY allows an endpoint to gracefully stop accepting new streams while
    still finishing processing of previously established streams."
    
    "Once the GOAWAY is sent, the sender will ignore frames sent on streams initiated
    by the receiver if the stream has an identifier higher than the included last stream identifier.
    Receivers of a GOAWAY frame MUST NOT open additional streams on the connection..."
    
    "A GOAWAY frame might not immediately precede closing of the connection"
    
    "Activity on streams numbered lower than or equal to the last stream identifier might still complete successfully.
    The sender of a GOAWAY frame might gracefully shut down a connection by sending a GOAWAY frame,
    maintaining the connection in an "open" state until all in-progress streams complete."
    
    Fix #2735
    violetagg committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    053a37e View commit details
    Browse the repository at this point in the history