Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When it is the last drained element do not schedule the flush operation #419

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

violetagg
Copy link
Member

@violetagg violetagg commented Aug 22, 2018

Related to #413

@violetagg violetagg changed the base branch from master to 0.7.x August 22, 2018 15:26
@violetagg violetagg added this to the 0.7.9.RELEASE milestone Aug 22, 2018
@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #419 into 0.7.x will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.7.x     #419      +/-   ##
============================================
- Coverage     69.02%   68.97%   -0.06%     
+ Complexity     1054     1053       -1     
============================================
  Files            72       72              
  Lines          4426     4428       +2     
  Branches        639      641       +2     
============================================
- Hits           3055     3054       -1     
+ Misses          985      984       -1     
- Partials        386      390       +4
Impacted Files Coverage Δ Complexity Δ
...or/ipc/netty/channel/ChannelOperationsHandler.java 64.62% <66.66%> (-0.29%) 60 <0> (ø)
...java/reactor/ipc/netty/channel/ContextHandler.java 72.81% <0%> (-2.92%) 26% <0%> (-1%)
...a/reactor/ipc/netty/channel/ChannelOperations.java 80.31% <0%> (-1.58%) 46% <0%> (-1%)
.../ipc/netty/channel/PooledClientContextHandler.java 68.06% <0%> (+3.36%) 27% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e079cab...43d5261. Read the comment docs.

@violetagg violetagg merged commit 43d5261 into 0.7.x Aug 23, 2018
@violetagg violetagg changed the title fix #413 When it is the last drained element do not schedule the flush operation When it is the last drained element do not schedule the flush operation Aug 23, 2018
@violetagg violetagg deleted the issue-413 branch August 23, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants