Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #850 Specify fire-and-forget dispose() behaviour for LoopResources, ConnectionProvider #851

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

violetagg
Copy link
Member

Specify fire-and-forget disposeLoopsAndConnections() behaviour for
TcpResources, HttpResources
Specify fire-and-forget shutdown() behaviour for UdpResources

@violetagg violetagg added this to the 0.9.0.RELEASE milestone Sep 18, 2019
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #851 into master will increase coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #851      +/-   ##
============================================
+ Coverage     67.47%   67.54%   +0.06%     
- Complexity     1466     1467       +1     
============================================
  Files           138      138              
  Lines          6829     6827       -2     
  Branches        871      871              
============================================
+ Hits           4608     4611       +3     
+ Misses         1754     1750       -4     
+ Partials        467      466       -1
Impacted Files Coverage Δ Complexity Δ
src/main/java/reactor/netty/udp/UdpResources.java 32.69% <ø> (+1.21%) 8 <0> (ø) ⬇️
...rc/main/java/reactor/netty/http/HttpResources.java 47.36% <ø> (ø) 5 <0> (ø) ⬇️
src/main/java/reactor/netty/tcp/TcpResources.java 57.14% <0%> (ø) 26 <0> (ø) ⬇️
...va/reactor/netty/resources/ConnectionProvider.java 75.67% <0%> (ø) 17 <0> (ø) ⬇️
...in/java/reactor/netty/resources/LoopResources.java 32.25% <0%> (ø) 9 <0> (ø) ⬇️
.../java/reactor/netty/channel/ChannelOperations.java 92.74% <0%> (-0.81%) 59% <0%> (-1%)
...c/main/java/reactor/netty/channel/FluxReceive.java 78.15% <0%> (+0.48%) 63% <0%> (+1%) ⬆️
...eactor/netty/http/client/HttpClientOperations.java 65.1% <0%> (+0.87%) 72% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24cc539...27e95c3. Read the comment docs.

Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mention combining disposeLater with blocking in these new docs, since otherwise it might lead people to think simply replacing dispose() with disposeLater() would work

@violetagg
Copy link
Member Author

I would mention combining disposeLater with blocking in these new docs, since otherwise it might lead people to think simply replacing dispose() with disposeLater() would work

done

…s, ConnectionProvider

Specify fire-and-forget disposeLoopsAndConnections() behaviour for
TcpResources, HttpResources
Specify fire-and-forget shutdown() behaviour for UdpResources
@violetagg violetagg merged commit 27e95c3 into master Sep 19, 2019
@violetagg violetagg deleted the issue-850 branch September 19, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants