Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve the errorprone warning. #862

Merged
merged 4 commits into from Sep 29, 2019
Merged

resolve the errorprone warning. #862

merged 4 commits into from Sep 29, 2019

Conversation

Liyixin95
Copy link
Contributor

Resolve some of the errorprone warning, including ReferenceEquality, StringSplitter, and suppress the unchecked , rawtype and deprecation warning.
There are still two type of warning unresolved, including FunctionalInerfaceMethodChanged and FutureReturnValueIgnored.Should I suppress them or resolve them?

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #862 into master will increase coverage by 0.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #862      +/-   ##
============================================
+ Coverage     67.01%   67.02%   +0.01%     
- Complexity     1502     1503       +1     
============================================
  Files           146      146              
  Lines          7072     7072              
  Branches        901      901              
============================================
+ Hits           4739     4740       +1     
  Misses         1852     1852              
+ Partials        481      480       -1
Impacted Files Coverage Δ Complexity Δ
...eactor/netty/http/client/HttpClientOperations.java 64.22% <ø> (+0.29%) 71 <0> (+1) ⬆️
.../java/reactor/netty/channel/BootstrapHandlers.java 72.26% <ø> (ø) 40 <0> (ø) ⬇️
...ctor/netty/resources/PooledConnectionProvider.java 82.35% <ø> (ø) 27 <0> (ø) ⬇️
...c/main/java/reactor/netty/http/HttpOperations.java 73.21% <ø> (ø) 30 <0> (ø) ⬇️
src/main/java/reactor/netty/ReactorNetty.java 71.71% <ø> (ø) 43 <0> (ø) ⬇️
...a/reactor/netty/http/client/HttpClientConnect.java 58.26% <ø> (ø) 4 <0> (ø) ⬇️
.../main/java/reactor/netty/channel/MonoSendMany.java 63.88% <ø> (ø) 4 <0> (ø) ⬇️
...eactor/netty/channel/ChannelOperationsHandler.java 79.62% <0%> (ø) 11 <0> (ø) ⬇️
...or/netty/http/server/HttpServerMetricsHandler.java 72.41% <100%> (ø) 11 <1> (ø) ⬇️
...java/reactor/netty/http/server/ConnectionInfo.java 95.08% <100%> (ø) 25 <0> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b12cff...c05f681. Read the comment docs.

@violetagg violetagg self-requested a review September 27, 2019 11:16
@violetagg violetagg added this to the 0.9.1.RELEASE milestone Sep 27, 2019
@violetagg violetagg added the type/enhancement A general enhancement label Sep 27, 2019
@violetagg violetagg merged commit 8ae1983 into reactor:master Sep 29, 2019
@violetagg
Copy link
Member

thanks

@Liyixin95
Copy link
Contributor Author

@violetagg What about the other two type of warning? Suppress or resolve? And I think the version of errorprone-gradle-plugin need to be update...

@violetagg
Copy link
Member

I suppressed some of them and updated the plugin to version 0.8.1

violetagg pushed a commit that referenced this pull request Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants