-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve the errorprone warning. #862
Conversation
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
============================================
+ Coverage 67.01% 67.02% +0.01%
- Complexity 1502 1503 +1
============================================
Files 146 146
Lines 7072 7072
Branches 901 901
============================================
+ Hits 4739 4740 +1
Misses 1852 1852
+ Partials 481 480 -1
Continue to review full report at Codecov.
|
src/main/java/reactor/netty/channel/ChannelOperationsHandler.java
Outdated
Show resolved
Hide resolved
thanks |
@violetagg What about the other two type of warning? Suppress or resolve? And I think the version of errorprone-gradle-plugin need to be update... |
I suppressed some of them and updated the plugin to version 0.8.1 |
Resolve some of the errorprone warning, including
ReferenceEquality
,StringSplitter
, and suppress theunchecked
,rawtype
anddeprecation
warning.There are still two type of warning unresolved, including
FunctionalInerfaceMethodChanged
andFutureReturnValueIgnored
.Should I suppress them or resolve them?