fix #970 Separate HTTP and WebSocket compression configuration when on the server side. #980
Conversation
| @@ -97,7 +97,7 @@ | |||
| .set(replaced.nettyRequest.headers()); | |||
|
|
|||
| if (channel().pipeline() | |||
| .get(NettyPipeline.CompressionHandler) != null) { | |||
| .get(NettyPipeline.CompressionHandler) != null || webSocketSpec.compress()) { | |||
There was a problem hiding this comment.
Maybe better move webSocketSpec.compress() to first check condition, because CompressionHandler can present but webSocketSpec.compress() is disabled. WDYT ?
There was a problem hiding this comment.
Done
Also the check with CompressionHandler will be removed in 1.0.x once I merge this change to master, but for 0.9.x we need to keep the current behaviour.
|
LGTM, @rstoyanchev how we can adopt this configuration to |
|
@amizurov if you could please start with a request in https://github.com/spring-projects/spring-framework to add a property for this, both client and server side. Similar to the |
…n the server side.
Fix #970