[OSK] Implement the welcome warning box on startup #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katahiromz
requested changes
Nov 2, 2018
GeoB99
force-pushed
the
osk-showwarning
branch
from
7aec329
to
c48a323
Compare
katahiromz
reviewed
Nov 2, 2018
katahiromz
requested changes
Nov 2, 2018
GeoB99
force-pushed
the
osk-showwarning
branch
2 times, most recently
from
e2eaddd
to
05ee917
Compare
katahiromz
approved these changes
Nov 2, 2018
GeoB99
force-pushed
the
osk-showwarning
branch
from
05ee917
to
8015e3e
Compare
ThFabba
reviewed
Nov 3, 2018
GeoB99
force-pushed
the
osk-showwarning
branch
3 times, most recently
from
8d9d41a
to
9203737
Compare
ThFabba
reviewed
Nov 3, 2018
ThFabba
reviewed
Nov 3, 2018
GeoB99
force-pushed
the
osk-showwarning
branch
2 times, most recently
from
7145047
to
59753e6
Compare
HBelusca
requested changes
Nov 16, 2018
GeoB99
force-pushed
the
osk-showwarning
branch
from
59753e6
to
b9b8b8d
Compare
|
@HBelusca Review addressed. |
HBelusca
approved these changes
Nov 17, 2018
In Windows XP, both in On-Screen Keyboard and in Magnify there's a welcome box which is shown upon startup of the application. Our Magnify already has this thing implemented meanwhile in On-Screen Keyboard it's not.
GeoB99
force-pushed
the
osk-showwarning
branch
from
b9b8b8d
to
dfbced4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In Windows XP, both Magnify and On-Screen Keyboard show to the screen a welcome dialog box informing the user about the purpose of those applications. This feature is already implemented for Magnify in ReactOS which however in On-Screen Keyboard is still unimplemented.
Presentation
URL Video: https://www.youtube.com/watch?v=daJdvnI5tiI
Proposed Changes
LoadDataFromRegistry()andSaveDataToRegistry()OSK_WarningProc()which is used for the handling of the dialog box