Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHPOLICY] Fix the missing backslash in SHRestricted #1267

Merged
merged 3 commits into from Mar 23, 2019
Merged

[SHPOLICY] Fix the missing backslash in SHRestricted #1267

merged 3 commits into from Mar 23, 2019

Conversation

dz333n
Copy link
Contributor

@dz333n dz333n commented Jan 19, 2019 •
edited

Purpose

I ran into a problem when I tried to implement NoSimpleStartMenu policy for explorer.

image
(message link)

There are no backslash between Policies and Explorer, we need to add one.

CORE-15666

Proposed changes

  • strcat backslash before strcat p->appstr

@dz333n dz333n mentioned this pull request Jan 19, 2019
Merged
4 tasks
@yagoulas
Copy link
Member

yagoulas commented Jan 19, 2019 •
edited

We should notify wine about this bug

@ThFabba ThFabba self-assigned this Jan 19, 2019
@tkreuzer tkreuzer added this to New PRs in ReactOS PRs Jan 19, 2019
@HBelusca HBelusca added the 3rd party sync Updating 3rd party components, such as Wine and others label Jan 19, 2019
@MailYouLater
Copy link

We should notify wine about this bug

Has anyone done this?

@dz333n
Copy link
Contributor Author

dz333n commented Jan 22, 2019

We should notify wine about this bug

Has anyone done this?

Seems like no

@yagoulas
Copy link
Member

I opened CORE-15666 to track this and coordinate with wine

@dz333n dz333n changed the title [SHPOLICY] Fix the missing backslash [SHPOLICY] Fix the missing backslash in SHRestricted Jan 22, 2019
@MailYouLater
Copy link

We should notify wine about this bug

Has anyone done this?

Seems like no

Since you're the author of this patch, this would usually fall on you. If you don't know how to submit a patch to wine, I would suggest you ask for help from someone who has done so in the past.

@dz333n
Copy link
Contributor Author

dz333n commented Jan 23, 2019

Since you're the author of this patch, this would usually fall on you. If you don't know how to submit a patch to wine, I would suggest you ask for help from someone who has done so in the past.

I will do everything later, don't have time for this right now. 😉

@MailYouLater
Copy link

If you go to the JIRA issue about this (thanks @yagoulas), you'll see that someone who has experience with submitting patches to wine has been pinged (we'll see if/when they reply) and that one of the devs is working on a test for SHRestricted, which should help.

@tkreuzer tkreuzer moved this from New PRs to WIP / Waiting on contributor in ReactOS PRs Feb 2, 2019
@tkreuzer tkreuzer added the WIP label Feb 2, 2019
@DarkShadow44
Copy link
Contributor

Many thanks for catching this, I took the liberty of sending your fix to wine, see https://source.winehq.org/patches/data/160651

@ThFabba ThFabba removed their assignment Mar 13, 2019
@BelleNottelling
Copy link
Contributor

Are we waiting for wine to fix this before we merge it?

@dz333n
Copy link
Contributor Author

dz333n commented Mar 19, 2019

Thank you @DarkShadow44

@DarkShadow44
Copy link
Contributor

Fixed in wine now: https://source.winehq.org/git/wine.git/?a=commit;h=dbbfa481539acd29de47ff6cd5cc2d24a2e01871

@MailYouLater
Copy link

MailYouLater commented Mar 21, 2019 •
edited

Also, there are several unnecessary merge commits in this PR's branch.
I recommend you use git rebase -i a97e456 to remove them (delete the lines the merge commits are on), then force push it to the dz3n-shpolicy-fix branch in your GitHub repo.

@dz333n
Copy link
Contributor Author

dz333n commented Mar 22, 2019

I have no access to git and computer right now, I'll do it later

@binarymaster
Copy link
Member

Well, anybody with push access to repo can fix it for you and then merge, if you checked the checkbox "Allow edits from maintainers".

@dz333n
Copy link
Contributor Author

dz333n commented Mar 22, 2019

Done

@HBelusca HBelusca self-assigned this Mar 23, 2019
@HBelusca HBelusca merged commit 3999e87 into reactos:master Mar 23, 2019
ReactOS PRs automation moved this from WIP / Waiting on contributor to Done Mar 23, 2019
@dz333n dz333n deleted the dz3n-shpolicy-fix branch March 23, 2019 19:04
@HBelusca HBelusca removed the WIP label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MailYouLater MailYouLater MailYouLater left review comments

@binarymaster binarymaster binarymaster approved these changes

Assignees

@HBelusca HBelusca

Labels
3rd party sync Updating 3rd party components, such as Wine and others
Projects
ReactOS PRs
  
Done
Milestone
No milestone
9 participants
@dz333n @yagoulas @MailYouLater @DarkShadow44 @BelleNottelling @binarymaster @tkreuzer @HBelusca @ThFabba