-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SHPOLICY] Fix the missing backslash in SHRestricted #1267
Conversation
We should notify wine about this bug |
Has anyone done this? |
Seems like no |
I opened CORE-15666 to track this and coordinate with wine |
Since you're the author of this patch, this would usually fall on you. If you don't know how to submit a patch to wine, I would suggest you ask for help from someone who has done so in the past. |
I will do everything later, don't have time for this right now. 😉 |
If you go to the JIRA issue about this (thanks @yagoulas), you'll see that someone who has experience with submitting patches to wine has been pinged (we'll see if/when they reply) and that one of the devs is working on a test for SHRestricted, which should help. |
Many thanks for catching this, I took the liberty of sending your fix to wine, see https://source.winehq.org/patches/data/160651 |
Are we waiting for wine to fix this before we merge it? |
Thank you @DarkShadow44 |
Also, there are several unnecessary merge commits in this PR's branch. |
I have no access to git and computer right now, I'll do it later |
Well, anybody with push access to repo can fix it for you and then merge, if you checked the checkbox "Allow edits from maintainers". |
a97e456
to
95a930a
Compare
Done |
Purpose
I ran into a problem when I tried to implement NoSimpleStartMenu policy for explorer.
(message link)
There are no backslash between
Policies
andExplorer
, we need to add one.CORE-15666
Proposed changes
strcat
backslash beforestrcat
p->appstr