Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPLORER] Add date tooltip to taskbar clock #1434

Merged
merged 2 commits into from
Mar 24, 2019
Merged

[EXPLORER] Add date tooltip to taskbar clock #1434

merged 2 commits into from
Mar 24, 2019

Conversation

b-r-o-c-k
Copy link
Contributor

@b-r-o-c-k b-r-o-c-k commented Mar 22, 2019 •
edited
Loading

Purpose

clock-tooltip

Add date tooltip to taskbar clock.

JIRA issue: CORE-11444

@HBelusca
Copy link
Contributor

HBelusca commented Mar 22, 2019 •
edited
Loading

Hi, thanks for the patch, but you certainly forgot to read https://github.com/reactos/reactos/blob/master/CONTRIBUTING.md#rules-and-recommendations and agree on it.

@binarymaster
Copy link
Member

@HBelusca author and email fields in the commit are ok.

@HBelusca
Copy link
Contributor

Ah ok, so one will have to use the "Rebase and merge" button to get it right (the "Squash" button would use github account details that would mess it up otherwise).

@b-r-o-c-k
Copy link
Contributor Author

The double-click action is working again and I updated my GitHub profile to include my name.

HBelusca
HBelusca reviewed Mar 23, 2019
View reviewed changes
base/shell/explorer/trayclock.cpp Outdated Show resolved Hide resolved
base/shell/explorer/trayclock.cpp Outdated Show resolved Hide resolved
base/shell/explorer/trayclock.cpp Outdated Show resolved Hide resolved
@b-r-o-c-k
[EXPLORER] Add date tooltip to taskbar clock
939bc9e 
CORE-11444
@b-r-o-c-k
Fix regression with double click action
a0061a7 
The double click action is now triggered by the WM_LBUTTONDBLCLK message
instead of WM_NCLBUTTONDBLCLK.
@HBelusca HBelusca merged commit fb4c9fb into reactos:master Mar 24, 2019
@HBelusca
Copy link
Contributor

Thanks for your contribution!

@b-r-o-c-k b-r-o-c-k deleted the clock-tooltip branch March 24, 2019 22:47
@JoachimHenze
Copy link
Contributor

Yes thank you for that feature b-r-o-c-k. Still can you have a look at this small glitch that the new feature introduced? https://jira.reactos.org/browse/CORE-16397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HBelusca HBelusca HBelusca left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b-r-o-c-k @HBelusca @binarymaster @JoachimHenze