Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOTEPAD] Add Croatian translation (hr-HR) #4338

Merged
merged 3 commits into from
Feb 9, 2022
Merged

[NOTEPAD] Add Croatian translation (hr-HR) #4338

merged 3 commits into from
Feb 9, 2022

Conversation

Andrej123456789
Copy link
Member

Purpose

Translate Notepad to Croatian
JIRA issue: N/A

Proposed changes

  • Upload hr-HR.rc

TODO

Nothing :)

Note

This is new Pull Request because old one had conflict.

@katahiromz katahiromz changed the title Notepad translation [NOTEPAD] Add Croatian translation (hr-HR) Feb 5, 2022
@katahiromz katahiromz added the TRANSLATION For translation and localization PRs label Feb 5, 2022
@katahiromz katahiromz added this to New PRs in ReactOS PRs via automation Feb 5, 2022
@Andrej123456789 @katahiromz
Update base/applications/notepad/lang/hr-Hr.rc
6ac20b0 
Co-authored-by: Katayama Hirofumi MZ <katayama.hirofumi.mz@gmail.com>
@katahiromz katahiromz merged commit e0fc48d into reactos:master Feb 9, 2022
ReactOS PRs automation moved this from New PRs to Done Feb 9, 2022
JoachimHenze added a commit that referenced this pull request Feb 11, 2022
@JoachimHenze
[NOTEPAD] Fix hr-Hr.rc compiler warning 'unrecognized escape sequence…
27d73cd 
…' CORE-18043

It regressed by 0.4.15-dev-3810-g e0fc48d (#4338)
No release was ever affected therefore.

The diff looks massive in tgit-diffview, strange,
but I actually replaced just a '\' with '\n' at line 168.
My local diff tool does properly display it as a one-line-change only.
binarymaster
binarymaster reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@binarymaster binarymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resource file name has incorrect letter case, this has to be fixed. Sorry for late review, I wanted to do it earlier, but was on vacation.

image

base/applications/notepad/lang/hr-Hr.rc Show resolved Hide resolved
binarymaster added a commit that referenced this pull request Feb 23, 2022
@binarymaster
[NOTEPAD] Fix Croatian (hr-HR) resource file
015fd3a 
Addendum to e0fc48d (#4338).
@binarymaster
Copy link
Member

Addressed in 015fd3a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarymaster binarymaster binarymaster left review comments

@katahiromz katahiromz katahiromz left review comments

Assignees
No one assigned
Labels
TRANSLATION For translation and localization PRs
Projects
ReactOS PRs
  
Done
Milestone
No milestone
3 participants
@Andrej123456789 @binarymaster @katahiromz