Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAPPS] Refreshing the Installed list should read everything from the registry #5676

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[RAPPS] Refreshing the Installed list should read everything from the registry #5676

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
225f390
Force refresh from the registry for installed items, and remember the…
whindsaks Sep 9, 2023
0a6ee73
Correctly ignore (unlikely) invalid HWND
whindsaks Sep 9, 2023
a290e36
Reorganize to avoid validating the handle in RestoreListSelection
whindsaks Sep 10, 2023
fd303d2
Fix merge conflicts
TAN-Gaming May 13, 2024
49d5117
- Use a struct to store the restore data
whindsaks May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions base/applications/rapps/gui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ CMainWindow::ShowAboutDlg()
VOID
CMainWindow::OnCommand(WPARAM wParam, LPARAM lParam)
{
BOOL bReload = TRUE;
const BOOL bReload = TRUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not then just put TRUE whenever bReload is used in this function?

Copy link
Contributor

@TAN-Gaming TAN-Gaming May 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the original code does this for ease of updating in the future ?

WORD wCommand = LOWORD(wParam);

if (!lParam)
Expand Down Expand Up @@ -536,7 +536,6 @@ CMainWindow::OnCommand(WPARAM wParam, LPARAM lParam)
break;

case ID_REFRESH:
bReload = IsInstalledEnum(SelectedEnumType); // Force installed refresh from the registry
UpdateApplicationsList(SelectedEnumType, bReload);
break;

Expand Down