-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAPPS] Refreshing the Installed list should read everything from the registry #5676
base: master
Are you sure you want to change the base?
Conversation
if (hList) | ||
{ | ||
Item.iItem = ListView_GetNextItem(hList, -1, LVNI_FOCUSED); | ||
ListView_GetItem(hList, &Item); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the convenience functions from the m_Listview itself?
stuff like m_ListView->GetItemData
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a MFC guy I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find the reference here:
https://doxygen.reactos.org/de/dfc/classCListView.html
This PR is stale because it received no updates in the last 4 months. Without removing the stale label, or commenting on this ticket it will be closed in 2 weeks. |
base/applications/rapps/gui.cpp
Outdated
@@ -479,7 +479,7 @@ CMainWindow::ShowAboutDlg() | |||
VOID | |||
CMainWindow::OnCommand(WPARAM wParam, LPARAM lParam) | |||
{ | |||
BOOL bReload = TRUE; | |||
const BOOL bReload = TRUE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not then just put TRUE whenever bReload is used in this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the original code does this for ease of updating in the future ?
- This PR is now only about restoring the selection since the refresh fix was added in another PR
The Installed list must re-enumerate the registry when F5 is pressed because just adding the same items from the cached list is pointless.
Most of the code is related to restoring the selected item and as a bonus, works in the other modes as well.