[RAPPS] Refreshing the Installed list should read everything from the registry #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarymaster
added
enhancement
HBelusca
reviewed
Sep 10, 2023
learn-more
reviewed
Sep 11, 2023
| if (hList) | ||
| { | ||
| Item.iItem = ListView_GetNextItem(hList, -1, LVNI_FOCUSED); | ||
| ListView_GetItem(hList, &Item); |
There was a problem hiding this comment.
Why not use the convenience functions from the m_Listview itself?
stuff like m_ListView->GetItemData etc.
There was a problem hiding this comment.
I'm not a MFC guy I guess.
There was a problem hiding this comment.
You can find the reference here:
https://doxygen.reactos.org/de/dfc/classCListView.html
|
This PR is stale because it received no updates in the last 4 months. Without removing the stale label, or commenting on this ticket it will be closed in 2 weeks. |
github-actions
bot
added
the
no-pr-activity
learn-more
approved these changes
Jan 10, 2024
github-actions
bot
removed
the
no-pr-activity
TAN-Gaming
reviewed
May 10, 2024
TAN-Gaming
reviewed
May 13, 2024
HBelusca
reviewed
May 13, 2024
base/applications/rapps/gui.cpp
Outdated
| @@ -479,7 +479,7 @@ CMainWindow::ShowAboutDlg() | |||
| VOID | |||
| CMainWindow::OnCommand(WPARAM wParam, LPARAM lParam) | |||
| { | |||
| BOOL bReload = TRUE; | |||
| const BOOL bReload = TRUE; | |||
There was a problem hiding this comment.
Why not then just put TRUE whenever bReload is used in this function?
There was a problem hiding this comment.
Maybe the original code does this for ease of updating in the future ?
- This PR is now only about restoring the selection since the refresh fix was added in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Installed list must re-enumerate the registry when F5 is pressed because just adding the same items from the cached list is pointless.
Most of the code is related to restoring the selected item and as a bonus, works in the other modes as well.