[RAPPS] Fix refresh not working correctly #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
binarymaster
approved these changes
May 9, 2024
Addendum to commit 33c2903 CORE-18459
TAN-Gaming
force-pushed
the
rapps-refresh-fix
branch
from
a6741e0
to
cfc3317
Compare
|
Is this not the same as my PR here? Only does the reload for the Installed items, not everything. |
HBelusca
approved these changes
May 9, 2024
whindsaks
requested changes
May 9, 2024
JoachimHenze
referenced
this pull request
May 10, 2024
Previously, there would be function duplication between installed and available applications. Now this is handled with polymorphism, which allows to re-use a lot of code. Additionally, toolbar buttons are properly disabled now. The mutex used to guard rapps' single instance is renamed, so that the 'new' and old rapps can be run at the same time for testing. CORE-18459
whindsaks
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix refresh not working correctly after commit 33c2903e
Before:
ReactOS-Before.webm
After:
ReactOS-After.webm
Jira issue: Related to CORE-18459