-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOTEPAD] Add Korean (ko-KR) translation #6907
base: master
Are you sure you want to change the base?
Conversation
Welcome to ReactOS development. At first, please read carefully the following articles: https://github.com/reactos/reactos/blob/master/CONTRIBUTING.md |
Do you agree with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify Font
Do you agree? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed translation of untranslated strings
Can you edit this file? |
Add Korean to rsrc.rc #ifdef LANGUAGE_KO_KR |
Cc @manatails for review. Also wanted to ping Luke Luo, but he's deleted. |
Add Korean
The tests are passed. Please wait patiently for review. By the way, can you tell us your full name? |
I would like to have the same VenusGirl as the contributor's name in Risoh Editor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your interest in ReactOS!
We ask our contributors to use their full name when committing.
Please amend your commit with your full name, and update this PR.
To change this for future PR's, you can update it for globally (for the system):
git config --global user.name "Your Name"
git config --global user.email you@example.com
Or just for the current repository:
git config user.name "Your Name"
git config user.email you@example.com
Also please set up your GitHub account accordingly, so maintainers can use Squash & Merge button without getting the author field modified back to nickname by GitHub, it's done in two steps:
- Set your full name in GitHub profile settings (it should match your
user.name
setting) Uncheck(addressed now)Keep my email addresses private
in GitHub email settings
Regards,
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Fix...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few modifications to make the translation more coherent.
* PROJECT: ReactOS Notepad | ||
* LICENSE: LGPL-2.1-or-later (https://spdx.org/licenses/LGPL-2.1-or-later) | ||
* PURPOSE: Korean resource file | ||
* TRANSLATOR: Copyright 2024 VenusGirl <venusgirl@outlook.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has to be your real name.
Korean