Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSDM] Fix label height in IDD_SYSSETTINGS dialog #958

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

binarymaster
Copy link
Member

@binarymaster binarymaster commented Oct 20, 2018

Purpose

This fixes checkbox rendering issue.

JIRA issue: CORE-13792

Proposed changes

  • Fix label height in russian translation. Other translations are ok.
  • Fix controls order in IDD_SYSSETTINGS dialog

@HBelusca
Copy link
Contributor

Isn't it due also to the description static text zone being too large?

@binarymaster
Copy link
Member Author

Isn't it due also to the description static text zone being too large?

Hmm... could be, let me check it.

@binarymaster binarymaster changed the title [SYSDM] Fix controls order in IDD_SYSSETTINGS dialog [SYSDM] Fix label height in IDD_SYSSETTINGS dialog Oct 21, 2018
@binarymaster
Copy link
Member Author

@HBelusca you're right:

image

Fixed that. Btw. other translations are not affected by this problem.

@HBelusca
Copy link
Contributor

Correctly reordering the elements in the dialog can be done too ;)

@Doug-Lyons
Copy link
Contributor

@binarymaster, what is the tool you are using in the screenshot?

This fixes checkbox rendering issue in russian translation.
Dialogs in other translations are ok.

CORE-13792
@HBelusca HBelusca merged commit 3290d46 into reactos:master Oct 21, 2018
@binarymaster
Copy link
Member Author

@Doug-Lyons it's Restorator 2007.

@binarymaster binarymaster deleted the sysdm-checkbox branch October 21, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants