New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support AAAA #58
support AAAA #58
Conversation
Awesome! |
IMHO we should add this 👍 |
Awesome! Functionally LGTM – But the goal is a bit unclear from an integrators view point, given that I don't see this being used anywhere? How is (can) this used or is this only an internal preparation? Also, this only handles parsing incoming responses, but we never actually prepare any such outgoing requests afaict? (Also applies to #59 afaict) |
@clue We use an |
@asm89 This is interesting! I don't see this covered anywhere in either the README, examples or functional tests, does it make sense to you to add functional/integration tests as part of this PR? 👍 |
It's covered in the
I'd rather see it being done in a follow up. The parser code is unit tested. We do use the executor directly now and it seems to work fine. The library does not have any integration tests for the Lines 113 to 132 in e09ca28
|
👍 from me on that. Although that would be better suited in a different PR.
Agreed, this fits perfectly in the way of small PR's we've been doing lately |
@asm89 Thanks for the background info! I was mostly curious as to how we should describe (sell) this feature in the README/CHANGELOG and I agree that it makes sense to get this in as-is 👍 A follow-up PR to document and test this "advanced usage" would be much appreciated 👍 Thanks for the high quality PR, LGTM! |
Thank you! |
Hi, this PR adds the AAAA record type to react/dns.