Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ext-eio #79

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Drop ext-eio #79

merged 1 commit into from
Apr 26, 2020

Conversation

WyriHaximus
Copy link
Member

No description provided.

@WyriHaximus WyriHaximus added this to the v0.2.0 milestone Feb 11, 2020
clue
clue reviewed Feb 23, 2020
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable considering how this extension has turned out to be somewhat unreliable 👍

@WyriHaximus WyriHaximus mentioned this pull request Feb 24, 2020
Open
@ghost
Copy link

ghost commented Apr 25, 2020

@WyriHaximus ping

@WyriHaximus WyriHaximus changed the title [WIP] Drop ext-eio Drop ext-eio Apr 26, 2020
@WyriHaximus WyriHaximus requested review from clue and jsor April 26, 2020 17:37
@WyriHaximus
Copy link
Member Author

@clue exactly, this PR Is ready for review

clue
clue approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code = better code 👍

@WyriHaximus WyriHaximus merged commit 373d705 into reactphp:master Apr 26, 2020
@enumag enumag mentioned this pull request Dec 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @jsor @clue