Ensure the first bit of body directly after the headers is emitted into the stream #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers not emitted from the stream but from the response never making it into the stream
jsor
reviewed
Oct 28, 2016
| @@ -156,7 +156,7 @@ public function handleData($data) | |||
|
|
|||
| $this->emit('response', array($response, $this)); | |||
|
|
|||
| $response->emit('data', array($bodyChunk, $response)); | |||
| $this->stream->emit('data', array($bodyChunk, $response)); | |||
There was a problem hiding this comment.
$response can / should be omitted here?
There was a problem hiding this comment.
Check you're right it should be omitted there, the data will flow through the stream to the response and the response will emit it again when data comes from the stream 👍
… data flowed through the stream into the response: reactphp#68 (comment)
jsor
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67