Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support union types and address deprecation of ReflectionType::getClass() (PHP 8+ / Promise v2) #198

Merged
merged 3 commits into from
Nov 6, 2021

Conversation

SimonFrings
Copy link
Member

For references concerning this pull request look into #197 and #176.

@SimonFrings SimonFrings changed the title Add PHP 8 support and address deprecation of ReflectionType::getClass() (promise-2.x) Support union types and address deprecation of ReflectionType::getClass() (promise-2.x) Oct 15, 2021
@SimonFrings SimonFrings changed the title Support union types and address deprecation of ReflectionType::getClass() (promise-2.x) Support union types, address deprecation of ReflectionType::getClass() and support PHP 8 (promise-2.x) Oct 28, 2021
@clue clue changed the title Support union types, address deprecation of ReflectionType::getClass() and support PHP 8 (promise-2.x) Support union types, address deprecation of ReflectionType::getClass() (PHP 8+ / Promise v2) Nov 4, 2021
@clue clue changed the title Support union types, address deprecation of ReflectionType::getClass() (PHP 8+ / Promise v2) Support union types and address deprecation of ReflectionType::getClass() (PHP 8+ / Promise v2) Nov 4, 2021
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for backporting this from #197, changes LGTM! :shipit:

@clue clue requested a review from WyriHaximus November 4, 2021 14:53
@WyriHaximus WyriHaximus merged commit b233f5f into reactphp:2.x Nov 6, 2021
@clue clue mentioned this pull request Nov 17, 2021
@pflueg
Copy link

pflueg commented Nov 26, 2021

Thanks alot for fixing this! @clue: Do you guys know, when the v2.9.0 will be released with it?

@clue
Copy link
Member

clue commented Nov 26, 2021

@pflueg Indeed discussed this earlier today and will look into this asap, hope to have something ready in the next couple of weeks!

@pflueg
Copy link

pflueg commented Nov 26, 2021

Cool - thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants