Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #105

Merged
merged 2 commits into from
Nov 18, 2017
Merged

Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #105

merged 2 commits into from
Nov 18, 2017

Conversation

carusogabriel
Copy link
Contributor

I use the PHPUnit\Framework\TestCase notation instead of PHPUnit_Framework_TestCase while extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.

I just need to bump PHPUnit version to ~4.8.35, that support this namespace.

WyriHaximus
WyriHaximus approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes perfect sense to make, paves the road to PHPUnit 6 and beyond

clue
clue reviewed Nov 17, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for you digging into this and filing this PR! The changes LGTM, does it make sense to you to add support for PHPUnit 5 and PHPUnit 6 as part of this PR? :shipit:

@carusogabriel
Copy link
Contributor Author

@clue Done. Added PHPUnit version 5 and 6 support.

clue
clue approved these changes Nov 18, 2017
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick update, changes LGTM! :shipit: 👍

@jsor jsor merged commit e44d759 into reactphp:master Nov 18, 2017
@carusogabriel carusogabriel deleted the phpunit branch November 18, 2017 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carusogabriel @jsor @WyriHaximus @clue